-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TransformAt for Polyline #1035
Merged
andrewheumann
merged 10 commits into
hypar-io:master
from
DmytroMuravskyi:dmuravskyi/polycurve-transform-at
Oct 31, 2023
Merged
Fix TransformAt for Polyline #1035
andrewheumann
merged 10 commits into
hypar-io:master
from
DmytroMuravskyi:dmuravskyi/polycurve-transform-at
Oct 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TransformAt used incorrect calculation `d = this.Length() * u` that is wrong when parameter is no longer in [0,1] domain.
…m/DmytroMuravskyi/Elements into dmuravskyi/polycurve-transform-at
Thanks @DmytroMuravskyi for continuing to dig us out after the curve changes :) |
# Conflicts: # CHANGELOG.md # Elements/test/IndexedPolyCurveTests.cs # Elements/test/PolylineTests.cs
Updated branch and solved conflicts |
wynged
requested review from
andrewheumann and
ikeough
and removed request for
andrewheumann
October 25, 2023 14:00
andrewheumann
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @ikeough)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BACKGROUND:
DESCRIPTION:
TESTING:
FUTURE WORK:
REQUIRED:
CHANGELOG.md
.COMMENTS:
This change is